Fix typo in token configuration documentation #3677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign off your commits to fix the DCO check. |
Signed-off-by: Giorgos Gaganis <[email protected]>
gaganis
force-pushed
the
typo_in_token_documentation
branch
from
1fd6041 to
f1541c0
Compare
sunyuhan1998
approved these changes
Jun 26, 2025
ilayaperumalg
added
documentation
| ---- | ||
|
|
||
| You can also set this configuration programmatically in your application code: | ||
| You can also get this configuration programmatically in your application code: |
There was a problem hiding this comment.
How about changing get this configuration to get environment variable?
You can also get environment variable programmatically in your application code:
There was a problem hiding this comment.
@dev-jonghoonpark Thanks for the review and suggestion. It would be nice to include your suggestion but the important fix is to change set -> get.
Since we haven't heard back from the author on this yet, I will go ahead and merge this PR as is for now.
spring-builds
pushed a commit
that referenced
this pull request
Jul 2, 2025
Fixes #3677 Signed-off-by: Giorgos Gaganis <[email protected]> (cherry picked from commit 4ec73e2)
|
@gaganis Thanks for the PR fixing the doc. |
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3677 Signed-off-by: Giorgos Gaganis <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3677 Signed-off-by: Giorgos Gaganis <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3677 Signed-off-by: Giorgos Gaganis <[email protected]> Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits